Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hackerFeaturesEnabled with featureSet #432

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Pepe20129
Copy link

No description provided.

Copy link
Contributor

@Dragorn421 Dragorn421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, I'll test later

fast64_internal/oot/__init__.py Outdated Show resolved Hide resolved
fast64_internal/oot/cutscene/exporter/functions.py Outdated Show resolved Hide resolved
@Dragorn421 Dragorn421 added the codebase Code maintenance/cleanup label Aug 22, 2024
@Dragorn421 Dragorn421 added this to the v2.4.0 milestone Aug 23, 2024
@Yanis002 Yanis002 added the oot Has to do with the Ocarina of Time 64 side label Dec 1, 2024
fast64_internal/oot/__init__.py Outdated Show resolved Hide resolved
fast64_internal/oot/file_settings.py Outdated Show resolved Hide resolved
fast64_internal/oot/scene/panels.py Outdated Show resolved Hide resolved
fast64_internal/oot/scene/operators.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Yanis002 Yanis002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just this and it should be good

@@ -77,7 +84,7 @@ class OOT_Properties(bpy.types.PropertyGroup):
"""Global OOT Scene Properties found under scene.fast64.oot"""

version: bpy.props.IntProperty(name="OOT_Properties Version", default=0)
hackerFeaturesEnabled: bpy.props.BoolProperty(name="Enable HackerOOT Features")
feature_set: bpy.props.EnumProperty(name="Feature Set", default="decomp", items=feature_set_enum)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
feature_set: bpy.props.EnumProperty(name="Feature Set", default="decomp", items=feature_set_enum)
feature_set: bpy.props.EnumProperty(name="Feature Set", default="default", items=feature_set_enum)

@Yanis002
Copy link
Contributor

Yanis002 commented Dec 7, 2024

actually there's other places where it checks for "decomp" instead of "default" (changing enums can be annoying)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codebase Code maintenance/cleanup oot Has to do with the Ocarina of Time 64 side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants